Lars Ingebrigtsen [Wed, 5 May 2021 07:41:49 +0000 (09:41 +0200)]
Make the ELC+ELN lines line up with the other lines
Eric Abrahamsen [Mon, 3 May 2021 16:14:24 +0000 (09:14 -0700)]
Add new defvoo nnimap-keepalive-intervals to Gnus nnimap servers
* lisp/gnus/nnimap.el (nnimap-keepalive-intervals): New per-server
config for customizing when keepalive commands are sent.
(nnimap-keepalive, nnimap-open-connection-1): Consult in these
places. Additionally, use nnimap-streaming -> t when sending the
keepalive NOOP, so we don't wait for the response.
* doc/misc/gnus.texi (Customizing the IMAP Connection): Document.
Basil L. Contovounesios [Tue, 4 May 2021 19:56:37 +0000 (20:56 +0100)]
Remove unused lexical variables in cc-defs.el
* lisp/progmodes/cc-defs.el (c-sc-scan-lists-no-category+1+1)
(c-sc-scan-lists-no-category+1-1, c-sc-scan-lists-no-category-1+1)
(c-sc-scan-lists-no-category-1-1): Remove unused lexical variable
'here' to pacify byte-compilation warnings in cc-engine.el.
Andrea Corallo [Tue, 4 May 2021 19:31:44 +0000 (21:31 +0200)]
* Do not try to load unexistent eln file if async compilation was skipped
* lisp/emacs-lisp/comp.el (comp-run-async-workers): Don't try to
load if the eln file was not produced.
Eli Zaretskii [Tue, 4 May 2021 17:37:33 +0000 (20:37 +0300)]
Fix infloop in lsp-mode
* src/indent.c (line_number_display_width): Make sure the selected
window's buffer is current before using display code on it:
redisplay assumes that the window's buffer is current at all
times. Reported by Evgeny Kurnevsky via lsp-mode's issue 1621,
https://github.com/emacs-lsp/lsp-mode/issues/1621.
Glenn Morris [Tue, 4 May 2021 14:50:28 +0000 (07:50 -0700)]
Merge from origin/emacs-27
40228fffd7 (origin/emacs-27) Fix code for newline-and-indent in skele...
56c4c8ef32 * lisp/jka-compr.el (jka-compr-uninstall): Fix function re...
Glenn Morris [Tue, 4 May 2021 14:50:28 +0000 (07:50 -0700)]
; Merge from origin/emacs-27
The following commits were skipped:
6a46d3d809 (emacs-27) ; Auto-commit of loaddefs files.
ccfd2e20a9 Fix GUD overlay arrows in M-x gdb when debugging over Tram...
e61688f87d Fix setting breakpoints in M-x gdb for remote files. Don'...
Glenn Morris [Tue, 4 May 2021 14:50:25 +0000 (07:50 -0700)]
Merge from origin/emacs-27
101a049f55 Improve doc string of 'tab-width'.
43c154404e * lisp/emacs-lisp/elp.el: Doc fixes.
1984213f62 * lisp/emacs-lisp/pp.el: Doc fixes.
6486c9dc73 * admin/make-tarball.txt: Note to update more files on web...
Basil L. Contovounesios [Tue, 4 May 2021 14:08:16 +0000 (15:08 +0100)]
Remove as of recently unused GDK macro
Its only use was removed in the recent change of 2021-04-27 "Major
rewrite of adjust_frame_size", announced in the following thread:
https://lists.gnu.org/r/emacs-devel/2021-04/msg01162.html
* src/gtkutil.c [USE_GTK && !HAVE_GTK3] (gdk_window_get_geometry):
Remove unused macro to pacify -Wunused-macros build warning.
Basil L. Contovounesios [Tue, 4 May 2021 09:36:56 +0000 (10:36 +0100)]
; Fix and simplify last change in bookmark.el.
Lars Ingebrigtsen [Tue, 4 May 2021 09:48:27 +0000 (11:48 +0200)]
Fix inconsistent behaviour in find-file-noselect when using nowarn
* lisp/files.el (after-find-file): Behave the same in when
warning/not warning (bug#47850). This fixes this test case:
(switch-to-buffer (find-file-noselect "non-existing-dir/test.el" t))
which would leave the buffer read-only.
Lars Ingebrigtsen [Tue, 4 May 2021 09:25:33 +0000 (11:25 +0200)]
Allow TAB to go to a key in EPA key buffers
* lisp/epa.el (epa--insert-keys): Allow TAB to go to the keys
(bug#47876).
Lars Ingebrigtsen [Tue, 4 May 2021 09:04:38 +0000 (11:04 +0200)]
Fix doc marker for previous bookmark NEWS change
Boruch Baum [Tue, 4 May 2021 08:58:52 +0000 (10:58 +0200)]
Fontify lines when setting a bookmark
* lisp/bookmark.el (bookmark-fontify): New user option (bug#48179).
(bookmark-face): New face.
(bookmark--fontify, bookmark--unfontify): New functions.
(bookmark-set-internal, bookmark--jump-via, bookmark-delete): Use
them.
Lars Ingebrigtsen [Tue, 4 May 2021 07:57:30 +0000 (09:57 +0200)]
Ensure updating the animated image in all windows
* lisp/image.el (image-show-frame): Simplify the window update --
pass in the buffer, which is a noop if the buffer isn't displayed.
Martin Rudalics [Tue, 4 May 2021 07:17:11 +0000 (09:17 +0200)]
Fix a problem with x_set_tab_bar_lines (Bug#46827)
* src/xfns.c (x_set_tab_bar_lines): Call
x_change_tab_bar_height only if the number of tab bar lines
changed from or to zero (Bug#46827).
* src/xterm.c (x_make_frame_visible): Make frame_size_history
update less noisy by doing it only if the frame wasn't visible
before.
Stefan Kangas [Mon, 3 May 2021 22:59:10 +0000 (00:59 +0200)]
; * etc/NEWS: Fix typo.
Philip K [Mon, 3 May 2021 09:35:41 +0000 (11:35 +0200)]
project--buffer-list: Avoid Tramp buffers when possible
* project.el (project--buffer-list): Add file-remote-p check.
Michael Albinus [Mon, 3 May 2021 14:52:18 +0000 (16:52 +0200)]
Fix unquoting of file names in subprocesses (Bug#48177)
* lisp/files.el (file-name-non-special):
Improve handling of inhibit-file-name-handlers.
* src/callproc.c (Fcall_process, call_process): Unquote infile,
error_file and output_file. (Bug#48177)
* test/lisp/files-tests.el (files-tests-file-name-non-special--subprocess)
(files-tests-file-name-non-special-file-name-all-completions)
(files-tests-file-name-non-special-file-name-completion): Adapt tests.
Mauro Aranda [Mon, 3 May 2021 13:54:28 +0000 (10:54 -0300)]
; * etc/tutorials/TUTORIAL.es: Fix grammar in recent change
Alan Third [Sun, 2 May 2021 21:38:13 +0000 (22:38 +0100)]
Fix incorrect resizing behaviour on macOS (bug#48157, bug#48162)
* src/nsterm.m ([EmacsView viewDidResize:]): The drawing buffer can be
resized independently of Emacs's idea of the frame size.
Co-authored-by: martin rudalics <rudalics@gmx.at>
Lars Ingebrigtsen [Mon, 3 May 2021 10:21:11 +0000 (12:21 +0200)]
ediff shouldn't alter the kill ring when copying a diff
* lisp/vc/ediff-util.el (ediff-copy-diff, ediff-pop-diff): Don't
alter the kill ring (bug#47881).
Lars Ingebrigtsen [Mon, 3 May 2021 09:51:53 +0000 (11:51 +0200)]
Speed up animation of non-displayed buffers
* lisp/image.el (image-show-frame): Don't force an update if the
buffer with the animation isn't in a window (bug#47895). Also
just update the window in question.
Lars Ingebrigtsen [Mon, 3 May 2021 09:45:22 +0000 (11:45 +0200)]
Speed up animation of non-displayed images
* lisp/image.el (image-animate): Only compute the animation data
once -- this avoids recomputing the image on every iteration when
the image is not displayed (bug#47895).
Lars Ingebrigtsen [Mon, 3 May 2021 08:45:30 +0000 (10:45 +0200)]
Note that function symbols are preferred in `add-hook'
* lisp/subr.el (add-hook): Note that FUNCTION should preferably be
a symbol (bug#47992).
Steve Purcell [Mon, 3 May 2021 07:41:44 +0000 (09:41 +0200)]
ruby-mode.el: puts and printf do not require args
* lisp/progmodes/ruby-mode.el (ruby-font-lock-keywords): puts and
printf can be called without arguments, so the font locking of
"bare" calls to either is incorrect. The fix is to font-lock them
as for other kernel methods which accepts zero or more arguments
(bug#48180).
Lele Gaifax [Mon, 3 May 2021 07:37:38 +0000 (09:37 +0200)]
Align TUTORIAL.it to the English version
* etc/tutorials/TUTORIAL.it: Reference 'describe-command' to replicate
recent change. Add also a space before '<Invio>' in several places,
mimicking the usage of <Return> in the English version (bug#48183).
Philipp Stephani [Sun, 2 May 2021 18:57:38 +0000 (20:57 +0200)]
Fix code for newline-and-indent in skeleton language.
The code for this is the symbol 'n', which is usually spelled as '\n'
here, not the character ?\n.
* doc/misc/autotype.texi (Skeleton Language): Fix item for
newline-and-indent.
Martin Rudalics [Sun, 2 May 2021 15:44:01 +0000 (17:44 +0200)]
Add two changes announced but not included in previous commit
* src/frame.c (adjust_frame_size): Remove extra
inhibit_horizontal/_vertical checks. Improve the implied
resize check when INHIBIT equals 2.
Stefan Kangas [Sun, 2 May 2021 15:35:55 +0000 (17:35 +0200)]
* etc/tutorials/TUTORIAL.sv: Adjust to latest change in TUTORIAL.
Stefan Kangas [Sun, 2 May 2021 15:35:31 +0000 (17:35 +0200)]
* etc/tutorials/TUTORIAL.es: Adjust to latest change in TUTORIAL.
Alan Mackenzie [Sun, 2 May 2021 15:22:36 +0000 (15:22 +0000)]
* lisp/progmodes/cc-defs (c-save-buffer-state): Amend debug spec, t to let*
This should solve part of bug #48100.
Eli Zaretskii [Sun, 2 May 2021 15:17:16 +0000 (18:17 +0300)]
* etc/tutorials/TUTORIAL.he: Adjust to latest change in TUTORIAL.
Stefan Kangas [Sun, 2 May 2021 13:04:00 +0000 (15:04 +0200)]
Add new help command 'describe-command'
* lisp/help-fns.el (describe-command): New command.
(help-fns--describe-function-or-command-prompt): New helper
function to prompt for a function or function. (Bug#46627)
(describe-function): Use above new helper function.
* lisp/help.el (help-map): Bind above new command to `C-h x'.
(help-for-help): Add this new command to the help summary.
* lisp/menu-bar.el (menu-bar-describe-menu): Add the new command to
the help menu.
* doc/emacs/help.texi (Help Summary, Name Help): Document
'describe-command', and update documentation on 'describe-function'.
* etc/tutorials/TUTORIAL: Change reference from 'describe-function' to
'describe-command'.
Stefan Monnier [Sun, 2 May 2021 12:40:28 +0000 (08:40 -0400)]
* lisp/apropos.el (apropos-value, apropos-local-value): Tweak for lexbind
Don't skip symbols for the nowadays lexically scoped local vars.
Basil L. Contovounesios [Sun, 2 May 2021 11:59:19 +0000 (12:59 +0100)]
; Fix last change in lisp/replace.el.
Alan Third [Sun, 2 May 2021 10:25:40 +0000 (11:25 +0100)]
Fix crash when resizing GNUstep builds
The toolkit can send far too many resize notifications, so be more
careful when we take action after receiving one.
* src/nsfns.m (ns_set_tool_bar_lines): Remove unneeded NSTRACE.
* src/nsterm.m ([EmacsView viewDidResize:]): Don't report resizes to
Emacs when the same change has already been reported and delayed.
Stefan Kangas [Sun, 2 May 2021 10:19:59 +0000 (12:19 +0200)]
* lisp/help-macro.el: Doc fix.
Stefan Kangas [Sun, 2 May 2021 10:10:54 +0000 (12:10 +0200)]
Bind S-SPC to scroll-down in help-for-help
* lisp/help-macro.el (make-help-screen): Bind S-SPC to
scroll-down. Thanks to Dmitry Gutov <dgutov@yandex.ru>.
Stefan Kangas [Sat, 1 May 2021 07:55:59 +0000 (09:55 +0200)]
Minor doc fixes in simple.el
* lisp/simple.el (next-error-move-function)
(next-error-found-function, next-error-found)
(previous-error-no-select, eval-expression-get-print-arguments)
(undo-adjust-elt, undo-adjust-beg-end): Minor doc fixes.
Nikolay Kudryavtsev [Sat, 1 May 2021 12:27:21 +0000 (15:27 +0300)]
Don't use pdumper-stats with unexec
* lisp/emacs-lisp/bytecomp.el (byte-compile-refresh-preloaded): Check if
pdumper-stats is bound before using it.
Lars Ingebrigtsen [Sun, 2 May 2021 09:28:30 +0000 (11:28 +0200)]
Inhibit lines in doc-view-mode
* lisp/doc-view.el (doc-view-mode): Inhibit line number modes
(bug#47974). Change suggested by Gregory Heytings.
Eric Skoglund [Sun, 2 May 2021 09:13:45 +0000 (11:13 +0200)]
Add newline and tab matching documentation to query-replace-regexp
* lisp/replace.el: Add \n and \t matching information to
query-replace-regexp docstring (bug#47981).
Lars Ingebrigtsen [Sun, 2 May 2021 08:41:49 +0000 (10:41 +0200)]
Tweak filtering some more
This should get the ./temacs continuation lines right.
Martin Rudalics [Sun, 2 May 2021 08:33:22 +0000 (10:33 +0200)]
Make adjust_frame_size set up frame's new_width/_height too (Bug#17120)
The purpose of this change is to have implied frame size changes
pick up sizes requested by previous explicit size changes not
only after they have been confirmed by the WM but already when
they are initially passed to adjust_frame_size (Bug#17120).
* src/dispextern.h (delayed_size_change): Remove extern.
* src/dispnew.c (delayed_size_change): Make static again.
(do_pending_window_change): Call change_frame_size only if F's
new_size_p flag is set.
(change_frame_size_1): Set/reset F's new_size_p flag
* src/frame.c (adjust_frame_size): Remove extra
inhibit_horizontal/_vertical checks. Improve the implied
resizes check with INHIBIT equals 2. Set F's new_width and
new_height and reset F's new_size_p flag when we run
set_window_size_hook with INHIBIT 0 or 1.
* src/frame.h (struct frame): New bit slot new_size_p.
* src/gtkutil.c (xg_frame_resized): Use F's new_size_p flag
instead of delayed_size_change to decide whether to call
change_frame_size.
(xg_frame_set_char_size): Call frame_size_history_extra before
waiting for the ConfigureNotify event.
* src/xterm.c (handle_one_xevent): Use F's new_size_p flag
instead of delayed_size_change to decide whether to call
change_frame_size.
Boruch Baum [Sun, 2 May 2021 08:22:21 +0000 (10:22 +0200)]
Suppress false positives in apropos-value
* lisp/apropos.el (apropos-value): Skip more apropos-internal
variables (bug#48063).
(apropos-value-internal): Skip the first value in the history
values, which always contains the match.
Philipp Stephani [Sat, 1 May 2021 23:01:28 +0000 (01:01 +0200)]
* lisp/jka-compr.el (jka-compr-uninstall): Fix function reference.
Stefan Monnier [Sat, 1 May 2021 19:51:52 +0000 (15:51 -0400)]
* lisp/simple.el (newline): Make the hook function remove itself
(copy-region-as-kill, kill-ring-save): Simplify interactive spec.
Stefan Monnier [Sat, 1 May 2021 19:30:57 +0000 (15:30 -0400)]
* lisp/minibuffer.el (completing-read-default): Fix bug#45474
Set `minibuffer-completion-*` variables buffer-locally instead of using
a global let-binding. This should also help make completion work
correctly when multiple minibuffers are simultaneously active.
Alan Third [Sat, 1 May 2021 16:50:25 +0000 (17:50 +0100)]
Fix infinite loop on GNUstep when toolbar updated
* src/nsterm.m ([EmacsView viewDidResize:]): Use Emacs's existing
knowledge of the frame size to decide whether to resize or not.
Alan Third [Sat, 1 May 2021 11:16:10 +0000 (12:16 +0100)]
Fix NS build warnings
* src/nsfns.m (Fx_create_frame): Remove unused variables.
Glenn Morris [Sat, 1 May 2021 13:29:15 +0000 (06:29 -0700)]
; Auto-commit of loaddefs files.
Glenn Morris [Sat, 1 May 2021 13:11:33 +0000 (06:11 -0700)]
; Auto-commit of loaddefs files.
Jim Porter [Sat, 1 May 2021 10:09:36 +0000 (12:09 +0200)]
Fix GUD overlay arrows in gdb-mi when debugging over Tramp
* lisp/progmodes/gdb-mi.el (gdb-frame-handler): Use local part of
file name when setting `gud-last-frame'.
Jim Porter [Sat, 1 May 2021 10:05:37 +0000 (12:05 +0200)]
Fix GUD overlay arrows in M-x gdb when debugging over Tramp. Don't merge
* lisp/progmodes/gdb-mi.el (gdb-frame-handler): Use local part of
file name when setting `gud-last-frame'.
Jim Porter [Sat, 1 May 2021 09:56:19 +0000 (11:56 +0200)]
Fix setting breakpoints in M-x gdb for remote files. Don't merge
* lisp/progmodes/gdb-mi.el (gdb-jsonify-buffer): Fix modification
of GDB/MI "fullname" property for remote files
Stefan Kangas [Fri, 30 Apr 2021 17:30:28 +0000 (19:30 +0200)]
Advertise PgUp/PgDn instead of SPC/DEL in help-for-help
* lisp/help-macro.el (make-help-screen):
* lisp/help.el (help-for-help): Advertise PgUp/PgDn instead of
SPC/DEL.
Mattias EngdegÄrd [Fri, 30 Apr 2021 15:09:21 +0000 (17:09 +0200)]
Don't signal scan-error in interactive sexp-based commands
This takes care of unfinished business from
df0f32f04850 (bug#43489).
* lisp/emacs-lisp/lisp.el (end-of-defun, mark-defun):
* lisp/reposition.el (reposition-window):
* lisp/simple.el (transpose-sexps): Convert nasty-looking scan-error
into a human-readable message.
Eli Zaretskii [Fri, 30 Apr 2021 11:22:29 +0000 (14:22 +0300)]
Fix the unexec build on MS-Windows
* src/buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: If dumped
with unexec, be sure to map new memory also for the " prin1"
buffer. For the reasons and discussion, see
https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg01401.html.
Eli Zaretskii [Fri, 30 Apr 2021 10:48:13 +0000 (13:48 +0300)]
Improve doc string of 'tab-width'.
* src/buffer.c (syms_of_buffer) <tab-width>: Clarify doc string.
(Bug#48058)
Lars Ingebrigtsen [Fri, 30 Apr 2021 08:41:18 +0000 (10:41 +0200)]
Alter `gnus-article-show-images' to re-display with images installed
* lisp/gnus/gnus-art.el (gnus-article-show-images): Reselect to
display HTML images.
Eli Zaretskii [Fri, 30 Apr 2021 07:28:50 +0000 (10:28 +0300)]
Improve support for 'display-line-numbers-width-start'
* lisp/display-line-numbers.el (display-line-numbers-width-start):
Allow the value to be a number. (Bug#48095)
(display-line-numbers-mode): Handle
'display-line-numbers-width-start' whose value is a number.
Stefan Monnier [Thu, 29 Apr 2021 22:11:04 +0000 (18:11 -0400)]
* src/doc.c (Fsnarf_documentation): Fix bug#48019
Don't presume that `custom-delayed-init-variables` holds a list.
Stefan Monnier [Thu, 29 Apr 2021 22:03:51 +0000 (18:03 -0400)]
* lisp/mail/supercite.el (sc-select-attribution): Fix lexical conversion
Mark `citation` and `attribution` as dynamically scoped around
`sc-attribs-postselect-hook`, as documented in the function's docstring.
Andrea Corallo [Thu, 29 Apr 2021 18:56:26 +0000 (20:56 +0200)]
* Improve `comp-normalize-valset' reproducibility (bug#48021)
* lisp/emacs-lisp/comp-cstr.el (comp-normalize-valset): Make
it more reproducible.
Glenn Morris [Thu, 29 Apr 2021 18:42:03 +0000 (11:42 -0700)]
Automatically generate texinfo.el internal autoloads
* lisp/textmodes/texinfo.el: Replace manual autoloads.
* lisp/textmodes/makeinfo.el (makeinfo-region, makeinfo-buffer)
(makeinfo-recenter-compilation-buffer):
* lisp/textmodes/texnfo-upd.el (texinfo-make-menu)
(texinfo-all-menus-update, texinfo-start-menu-description)
(texinfo-indent-menu-description, texinfo-master-menu)
(texinfo-update-node, texinfo-every-node-update)
(texinfo-sequential-node-update, texinfo-insert-node-lines)
(texinfo-multiple-files-update):
Add autoload cookies, and set generated-autoload-file.
Stefan Kangas [Thu, 29 Apr 2021 15:17:50 +0000 (17:17 +0200)]
* lisp/emacs-lisp/elp.el: Doc fixes.
Michael Albinus [Thu, 29 Apr 2021 13:04:51 +0000 (15:04 +0200)]
Some Tramp corrections, Bug#48067
* doc/misc/tramp.texi (Frequently Asked Questions): Rephrase GNU
ELPA warnings.
* lisp/net/tramp-sh.el (tramp-sh-gio-monitor-process-filter):
Improve handling of gio warning. (Bug#48067)
Stefan Kangas [Thu, 29 Apr 2021 11:44:54 +0000 (13:44 +0200)]
* lisp/emacs-lisp/pp.el: Doc fixes.
Stefan Kangas [Thu, 29 Apr 2021 11:32:10 +0000 (13:32 +0200)]
* lisp/emacs-lisp/shortdoc.el: Doc fixes.
Dmitry Gutov [Thu, 29 Apr 2021 01:59:28 +0000 (04:59 +0300)]
* lisp/progmodes/project.el: Also bump version.
Dmitry Gutov [Thu, 29 Apr 2021 01:53:37 +0000 (04:53 +0300)]
* lisp/progmodes/xref.el: Bump version.
Juri Linkov [Wed, 28 Apr 2021 20:25:08 +0000 (23:25 +0300)]
* lisp/window.el (window--state-put-2): Set next/prev-buffers even to nil.
When next-buffers or prev-buffers are nil, still use set-window-next-buffers
or set-window-prev-buffers to set next/prev-buffers to nil. (Bug#46904)
Andrea Corallo [Wed, 28 Apr 2021 20:00:12 +0000 (22:00 +0200)]
* Add a note related to native compilation and Dynamic Binding
* doc/lispref/variables.texi (Dynamic Binding): Add a note
related to native compilation.
Michael Albinus [Wed, 28 Apr 2021 20:00:55 +0000 (22:00 +0200)]
Tramp code cleanup
* lisp/net/tramp-archive.el (tramp-archive-handle-insert-file-contents):
Code cleanup.
* lisp/net/tramp.el: Reload `tramp-compat' when we reload
`tramp-autoloads'.
(with-tramp-file-property, with-tramp-connection-property):
Use `tramp-cache-undefined'.
(tramp-autoload-file-name-handler): Do not load tramp-compat.el.
(tramp-handle-insert-file-contents): Code cleanup.
Michael Albinus [Wed, 28 Apr 2021 17:29:36 +0000 (19:29 +0200)]
Fix gio warning in Tramp
* lisp/net/tramp-sh.el (tramp-sh-gio-monitor-process-filter):
Improve handling of gio warning. (Bug#48067)
Eli Zaretskii [Wed, 28 Apr 2021 16:36:42 +0000 (19:36 +0300)]
Doc fixes in avl-tree.el
* lisp/emacs-lisp/avl-tree.el (avl-tree--root)
(avl-tree--dir-to-sign, avl-tree--sign-to-dir)
(avl-tree--del-balance, avl-tree--enter-balance)
(avl-tree--do-copy, avl-tree--stack-repopulate, avl-tree-empty)
(avl-tree-delete, avl-tree-member, avl-tree-member-p)
(avl-tree-map, avl-tree-mapc, avl-tree-mapf, avl-tree-mapcar)
(avl-tree-copy, avl-tree-clear, avl-tree-stack)
(avl-tree-stack-first): Fix doc strings to be less verbose and to
have the first line a complete sentence.
Stefan Kangas [Wed, 28 Apr 2021 14:02:42 +0000 (16:02 +0200)]
* lisp/emacs-lisp/avl-tree.el: Minor doc fixes.
Stefan Kangas [Wed, 28 Apr 2021 13:22:11 +0000 (15:22 +0200)]
* admin/make-tarball.txt: Note to update more files on web page.
Michael Albinus [Wed, 28 Apr 2021 08:05:53 +0000 (10:05 +0200)]
Improve add-log-current-defun-header-regexp
* lisp/vc/add-log.el (add-log-current-defun-header-regexp):
Allow digits. Require at least one letter. (Bug#48037)
Peter Oliver [Wed, 28 Apr 2021 02:18:40 +0000 (05:18 +0300)]
Add tests
* test/lisp/progmodes/ruby-mode-tests.el (ruby-with-temp-file): New helper.
(ruby--set-encoding-when-ascii, ruby--set-encoding-when-utf8)
(ruby--set-encoding-when-latin-15): Tests for the previous commit (bug#48043).
Dmitry Gutov [Wed, 28 Apr 2021 02:11:36 +0000 (05:11 +0300)]
Don't add magic comment to Ruby files for utf-8 encoding
* lisp/progmodes/ruby-mode.el (ruby-encoding-map):
Add entry for utf-8 (bug#48043).
(ruby--detect-encoding): Don't convert to string too early, so
that returning nil is meaningful.
(ruby-mode-set-encoding): Convert to string here.
Andrea Corallo [Tue, 27 Apr 2021 21:10:05 +0000 (23:10 +0200)]
* Clean-up temporary eln test-suite directory when exiting (bug#48060)
* lisp/startup.el (normal-top-level): Remove eln test-suite temp
dir when exiting.
Andrea Corallo [Tue, 27 Apr 2021 20:43:12 +0000 (22:43 +0200)]
Have `comp-cstr-intersection-no-mem' intersect pos neg value sets
* lisp/emacs-lisp/comp-cstr.el (comp-cstr-intersection-no-mem):
intersect pos and neg value sets
* test/lisp/emacs-lisp/comp-cstr-tests.el
(comp-cstr-typespec-tests-alist): Add two tests and fix some
test number.
Stefan Kangas [Tue, 27 Apr 2021 20:53:04 +0000 (22:53 +0200)]
Avoid missing whitespace in help-for-help
* lisp/help.el (help--for-help-make-commands): Avoid missing
whitespace before description of command.
Problem reported by Dmitry Gutov <dgutov@yandex.ru>.
Michael Albinus [Tue, 27 Apr 2021 18:56:07 +0000 (20:56 +0200)]
Fix loading problem in Tramp
* lisp/net/tramp.el (tramp-autoload-file-name-handler): Load also
tramp-compat.el.
Eli Zaretskii [Tue, 27 Apr 2021 18:51:57 +0000 (21:51 +0300)]
; * src/comp.c: Fix typos.
Stefan Kangas [Tue, 27 Apr 2021 16:54:37 +0000 (18:54 +0200)]
; Fix typos
Daniel Mendler [Tue, 27 Apr 2021 16:44:41 +0000 (19:44 +0300)]
(affixation-function): Allow only three-element list elements
Restrict the definition of the `affixation-function`. The function
must return a list of three element lists. Since the
`affixation-function` is part of the widely used `completing-read` API
a simplification is helpful for both authors of completion UIs and
authors of completion tables.
* doc/lispref/minibuf.texi: Update documentation.
* lisp/minibuffer.el: Update documentation.
* lisp/simple.el (read-extended-command--affixation):
Return three-element lists.
https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg01193.html
Mattias EngdegÄrd [Tue, 27 Apr 2021 15:36:15 +0000 (17:36 +0200)]
Calc: control digits after decimal point (bug#47302)
Calc normally displays a trailing decimal point for floats with no
fractional part, like '12.'. Some uses require at least one digit
after the point; add the governing variable calc-digit-after-point.
* lisp/calc/calc.el (calc-digit-after-point): New variable.
(math-format-number): Use it.
* test/lisp/calc/calc-tests.el (calc-display-digit-after-point):
New test.
Stefan Kangas [Tue, 27 Apr 2021 12:17:44 +0000 (14:17 +0200)]
; * lisp/emacs-lisp/comp.el: Fix typos. Add LocalWords.
Michael Albinus [Tue, 27 Apr 2021 10:28:02 +0000 (12:28 +0200)]
; * test/infra/gitlab-ci.yml: Add local variable.
Martin Rudalics [Tue, 27 Apr 2021 07:53:42 +0000 (09:53 +0200)]
Major rewrite of adjust_frame_size
Have adjust_frame_size pass native frame sizes to backends
instead of text sizes. Expand frame size history management.
Drop PIXELWISE argument from change_frame_size and convert
native to text sizes only when calling adjust_frame_size. Use
convention in arguments that -1 instead of 0 means that no size
change is required. When adjusting frame sizes pick up delayed
size changes (Bug#46827).
* lisp/frame.el (frame-notice-user-settings, make-frame): Don't
set frame size history.
(frame--size-history): Rewrite doc-string. Handle new formats
of `frame-size-history' entries.
* src/dispextern.h (delayed_size_change): Extern it.
(change_frame_size): Drop last argument from extern.
* src/dispnew.c (delayed_size_change): Make it global.
(handle_window_change_signal): Reformat. Drop last argument
from change_frame_size call.
(do_pending_window_change, init_display_interactive): Drop last
argument from change_frame_size call.
(change_frame_size_1): NEW_WIDTH and NEW_HEIGHT now specify
native sizes. Drop last argument PIXELWISE. Queue a change
when it either differs from F's current pixel sizes or F's
previously queued sizes. Inject frame_size_history_extra call
when queuing. Adopt convention that for queued sizes -1 means
that no size change is required. Convert from native to text
sizes when calling adjust_frame_size.
(change_frame_size): Drop last argument PIXELWISE and drop it
also in change_frame_size_1 calls.
* src/frame.c (frame_size_history_add): Remove.
(frame_inhibit_resize): Remove call to frame_size_history_add.
(set_menu_bar_lines, set_tab_bar_lines): Simplify. Drop last
argument from change_frame_size call.
(frame_windows_min_size): No more static.
(keep_ratio): Minor rewrite using macros.
(frame_size_history_adjust, frame_size_history_plain)
(frame_size_history_extra): New functions.
(adjust_frame_size): Major rewrite. Adopt new convention that
negative values for new sizes mean no change. Pick up delayed
size changes from F's new_width and new_height slots
(Bug#46827). Call set_window_size_hook with native instead of
text sizes. Do not sanitize window sizes any more. Call
frame_size_history_adjust instead of frame_size_history_add.
Always set F's resized_p slot to true.
(make_frame): Initialize new_width and new_height slots to -1.
Simplify setup of initial sizes and an adjust_frame_size call.
(Fframe_parameters): Drop processing F's new_pixelwise slot.
(check_frame_pixels): Reorder to make declarations appear first.
(Fset_frame_height, Fset_frame_width, Fset_frame_size): Pass
explicit width and height values to adjust_frame_size instead of
-1.
(gui_set_frame_parameters): Minor rewrite making sure that
explicit sizes and the corresponding parameter are passed to
adjust_frame_size. Remove frame_size_history_add call.
(gui_figure_window_size): Drop last two arguments. Simplify
assignment of initial size. Set new_height and new_width slots
to -1. Use adjust_frame_size to set sizes instead of returning
them to caller.
(syms_of_frame): Drop symbols used by frame size history; these
are now built on-the-fly. Also drop some menu bar related
symbols in favor of Qmenu_bar_lines.
* src/frame.h (struct frame): Remove new_pixelwise.
(SET_FRAME_COLS, SET_FRAME_LINES, SET_FRAME_WIDTH)
(SET_FRAME_HEIGHT): Remove macros.
(frame_size_history_add): Remove externs.
(frame_windows_min_size, frame_size_history_plain)
(frame_size_history_extra): Add externs.
(FRAME_WINDOWS_WIDTH, FRAME_WINDOWS_HEIGHT): Rename to
FRAME_INNER_WIDTH and FRAME_INNER_HEIGHT.
(gui_figure_window_size): Drop last two arguments from
extern.
* src/gtkutil.c (xg_frame_resized): Rename arguments to WIDTH
and HEIGHT. Consult delayed_size_change to handle case where
WIDTH and HEIGHT do not match F's new_width and new_height
values. Call change_frame_size with native sizes and without
PIXELWISE argument. Instead of frame_size_history_add call
frame_size_history_extra.
(xg_frame_set_char_size): WIDTH and HEIGHT are native sizes now;
fix adjust_frame_size call accordingly. Instead of
frame_size_history_add call frame_size_history_extra.
(style_changed_cb): Call xg_frame_set_char_size with native
instead of text sizes.
(tb_size_cb): Remove frame_size_history_add call. Call
adjust_frame_size with INHIBIT 5.
(free_frame_tool_bar, xg_change_toolbar_position): Remove
frame_size_history_add call.
(update_frame_tool_bar): Call adjust_frame_size with INHIBIT 2
and let it handle frame_inhibit_implied_resize and
fullheight/-width. Remove frame_size_history_add call.
* src/keyboard.c (Fsuspend_emacs): Call change_frame_size with
native sizes.
* src/nsfns.m (ns_set_tool_bar_lines): Call adjust_frame_size
with INHIBIT 2 and let it handle frame_inhibit_implied_resize
and fullheight/-width. Remove frame_size_history_add call.
(Fx_create_frame): Drop two last arguments in
gui_figure_window_size call. Do not SET_FRAME_WIDTH and
SET_FRAME_HEIGHT, the adjust_frame_size in
gui_figure_window_size did that already.
* src/nsterm.m (ns_set_window_size): Drop PIXELWISE argument and
its processing; WIDTH and HEIGHT represent native pixel sizes
now. Call change_frame_size with native sizes. Remove call to
frame_size_history_add.
([EmacsView viewDidResize:]): Call change_frame_size with native
sizes.
* src/term.c (Fresume_tty): Call change_frame_size with native
sizes.
* src/termhooks.h (*set_window_size_hook): Drop last argument
PIXELWISE.
* src/w32fns.c (w32_change_tab_bar_height)
(w32_change_tool_bar_height): Fix handling of these in the initial
phase before they have been resized at least once.
(Fx_create_frame, w32_create_tip_frame): Drop two last arguments
in gui_figure_window_size call. Do not SET_FRAME_WIDTH and
SET_FRAME_HEIGHT (or SET_FRAME_COLS and SET_FRAME_LINES), the
adjust_frame_size in gui_figure_window_size did that already.
* src/w32inevt.c (resize_event, maybe_generate_resize_event):
Pass native sizes to change_frame_size.
* src/w32term.c (w32_read_socket): When WM_WINDOWPOSCHANGED pass
native sizes to change_frame_size.
(w32_new_font): Recalculate FRAME_TAB_BAR_HEIGHT. Simplify
code.
(w32fullscreen_hook): Call change_frame_size with native sizes.
(w32_set_window_size): Drop argument PIXELWISE and its
processing; WIDTH and HEIGHT are native sizes now. Remove
frame_size_history_add calls. Pass native sizes to
change_frame_size.
* src/widget.c (set_frame_size): Set width and height of widget
directly. Call frame_size_history_plain instead of
frame_size_history_add.
(update_from_various_frame_slots): Call
frame_size_history_extra.
(EmacsFrameRealize): Call frame_size_history_plain.
(EmacsFrameResize): Call change_frame_size with native sizes.
Call frame_size_history_extra instead of frame_size_history_add.
(EmacsFrameSetCharSize): Call frame_size_history_extra. Drop
PIXELWISE argument in x_set_window_size call and specify pixels.
(pixel_to_text_size): Remove function.
* src/xdisp.c (resize_mini_window): Replace FRAME_WINDOWS_HEIGHT
with FRAME_INNER_HEIGHT.
(redisplay_tab_bar): Don't set tab_bar_redisplayed when we did
not redisplay it.
(redisplay_tool_bar): Don't call it for external tool bar.
Don't set tool_bar_redisplayed when we did not redisplay it.
(redisplay_window): When the tool bar is external call
update_frame_tool_bar directly.
* src/xfns.c (x_set_menu_bar_lines): Call adjust_frame_size only
if number of menu bar lines changed and fix 6th argument.
(x_change_tab_bar_height, x_change_tool_bar_height): Fix
handling of these in the initial phase before they have been
resized at least once.
(Fx_create_frame, x_create_tip_frame): Drop two last arguments
in gui_figure_window_size call. Do not SET_FRAME_WIDTH and
SET_FRAME_HEIGHT (or SET_FRAME_COLS and SET_FRAME_LINES), the
adjust_frame_size in gui_figure_window_size did that already.
* src/xmenu.c (update_frame_menubar): Fix 6th arg of
adjust_frame_size call.
(free_frame_menubar): For Motif frames fix fullscreen and
`frame-inhibit-implied-resize' handling. Fix 6th arg of
adjust_frame_size calls.
* src/xterm.c (x_net_wm_state): Remove call to
frame_size_history_add.
(handle_one_xevent): For PropertyNotify and UnmapNotify events
add frame_size_history_plain calls. For MapNotify and
ConfigureNotify events add a frame_size_history_extra call. For
ConfigureNotify events also handle delayed size changes and call
change_frame_size with native sizes.
(x_new_font): Recalculate FRAME_TAB_BAR_HEIGHT. Simplify code.
(x_handle_net_wm_state): Remove frame_size_history_add call.
(x_check_fullscreen): Remove frame_size_history_add call. Call
change_frame_size with native height.
(x_set_window_size_1): WIDTH and HEIGHT are now native. Remove
some frame_size_history_add calls and add frame_size_history_extra
calls instead. If the frame is not visible call adjust_frame_size
directly instead of calling change_frame_size.
(x_set_window_size): Drop PIXELWISE argument. WIDTH and HEIGHT
represent native sizes now.
(x_make_frame_visible, x_make_frame_invisible): Call
frame_size_history_plain.
* src/xterm.h (x_set_window_size): Drop last argument from
extern declaration.
Glenn Morris [Tue, 27 Apr 2021 05:18:14 +0000 (22:18 -0700)]
Doc fixes for comp.el
* lisp/emacs-lisp/comp.el (comp-deferred-compilation-deny-list)
(comp-bootstrap-deny-list, comp-pred-to-cstr, make-comp-mvar)
(comp-mvar-used-p, comp-async-compilation): Doc fixes.
Glenn Morris [Tue, 27 Apr 2021 05:09:46 +0000 (22:09 -0700)]
Fix some custom types in comp.el
* lisp/emacs-lisp/comp.el (comp-deferred-compilation-deny-list)
(comp-bootstrap-deny-list, comp-never-optimize-functions)
(comp-async-env-modifier-form, comp-native-driver-options):
Fix :type (`list' on its own isn't even a valid type).
Amin Bandali [Tue, 27 Apr 2021 03:58:05 +0000 (23:58 -0400)]
* lisp/erc/erc.el: Add past maintainer Michael Olson to Contributors.
Lars Ingebrigtsen [Tue, 27 Apr 2021 02:25:23 +0000 (04:25 +0200)]
Fix compilation warnings in non-toolkit builds
* src/xterm.c (x_create_toolkit_scroll_bar)
(x_create_horizontal_toolkit_scroll_bar): String constants for
XtSetArg are defined as const strings (in
/usr/include/X11/Xaw3d/ThreeD.h, for instance), but the argument
in XtSetArg is defined as either a const char* or a regular char*
in /usr/include/X11/Intrinsic.h. Cast the argument to String
(which should be correct on all platforms, hopefully) to avoid a
compilation warning (bug#47452).
Stefan Kangas [Tue, 27 Apr 2021 01:37:43 +0000 (03:37 +0200)]
Rename abnormal hook to comp-async-cu-done-functions
* lisp/emacs-lisp/comp.el (comp-async-cu-done-functions): Rename
from 'comp-async-cu-done-hook' to reflect that it is an abnormal
hook. Doc fix and update single caller.
Lars Ingebrigtsen [Mon, 26 Apr 2021 23:31:52 +0000 (01:31 +0200)]
Fix failing subr test
* test/lisp/subr-tests.el (subr-tests-bug22027): Fix mocked
signature of `read-string' (bug#48022).
Lars Ingebrigtsen [Mon, 26 Apr 2021 23:27:58 +0000 (01:27 +0200)]
Fix failing auth-source test
* test/lisp/auth-source-tests.el
(auth-source-test-secrets-create-secret): Fix test failing because
the mocked `read-string' had the wrong interface.